Codecov Report

❌ Patch coverage is 90.27778% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.99%. Comparing base (bb822f8) to head (b431c27).

@@             Coverage Diff             @@
##           develop    #4416      +/-   ##
===========================================
+ Coverage    51.76%   51.99%   +0.22%     
===========================================
  Files          453      454       +1     
  Lines        12014    12075      +61     
  Branches      2079     2092      +13     
===========================================
+ Hits          6219     6278      +59     
  Misses        5181     5181              
- Partials       614      616       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PR Review: dashboardPersonalizationLessons

8 commits · Lessons dashboard personalization feature

Summary

Adds a personalization toggle to the Lessons dashboard that lets users switch between a country-personalized view and an all-lessons view. Introduces LessonsFlowProducer as a dedicated flow provider, wires LessonsPresenter to a sync task registry via CircuitContext, and covers everything with unit, presenter, and Paparazzi snapshot tests.

Checklist Findings

✅ Looks Good

• ktlint — clean pass, no violations
• Circuit patterns — UiState/UiEvent properly nested in LessonsPresenter; UiEvent is internal sealed interface; eventSink exposed on UiState; UI delegates through state.eventSink(UiEvent.*) exclusively
• @ConsistentCopyVisibility + internal constructor on UiState — correct Kotlin 2 idiom; prevents external modules from constructing or copy()-ing state
• LessonsFlowProducer extraction — clean separation; flow logic moved out of the presenter correctly
• rememberSaveable for mode — survives process death; state restoration test verifies this
• CircuitContext as @Assisted — correct pattern for accessing registry in a presenter; factory updated to match
• DisposableEffect for sync task lifecycle — properly registers/unregisters on locale change
• modifier: Modifier = Modifier — present on all composable entry points (LessonsLayout, PersonalizationToggle, LessonsHeader)
• Theme / colors — no per-module theme introduced; existing MaterialTheme usage unchanged
• String resources — old dashboard_lessons_header_title key renamed to _personalized in all 24 locale files; new _all, toggle_* keys added to base only (expected — translations go through the localization pipeline)
• No unrelated formatter churn — stat confirms only intentional changes
• Test coverage — LessonsFlowProducerTest (pure JVM), LessonsPresenterTest (Robolectric + Circuit test API), LessonsLayoutTest (Compose UI, v2 runComposeUiTest)
• Paparazzi — snapshots not recorded locally; old snapshot files removed, new ones committed via CI workflow

⚠️ Minor Issues

• LessonsFlowProducer.kt:28,32 — Nested lambdas both use implicit it, shadowing the outer it:

  .map { it.sortedBy { it.defaultOrder } }   // line 28
  // ...
  baseFlow.map { it.filterNot { it.isHidden } }  // line 32

  Shadowing is valid Kotlin and ktlint doesn't flag it, but naming the outer parameter (tools ->) would make the type clearer at a glance. Low priority.

❌ Must Fix

(none)

Overall Verdict

APPROVE

A clean, well-structured feature. Good separation of concerns with LessonsFlowProducer, correct Circuit patterns throughout, solid test coverage across all three layers, and proper encapsulation with @ConsistentCopyVisibility. The only note is a cosmetic lambda naming nit in LessonsFlowProducer that isn't worth holding up the PR.

🤖 Generated with Claude Code